Welcome @liztio!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liztio
To complete the pull request process, please assign droot
You can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

I don't think I fully understand the implications of bumping client-go, is that likely to break other things?

/assign @DirectXMan12 @fanzhangio

This issue is affecting us in cluster-api where the Spam Filter is eating events we are generating.

implications of bumping client-go

Yeah, this needs to be done carefully otherwise we accidentally break backwards compat

besides the aforementioned bump issues (might just pull that in in #588 anyway), this needs at least one of

• good docs
• a sane wrapper

Alternatively, maybe we should just bump this up a level and let you set the recorder-provider directly?

That way we don't need to carry a rather niche dependency on some highly-implementation-specific options

Alternatively, maybe we should just bump this up a level and let you set the recorder-provider directly?

that makes sense to me, let me mock up a PR rq

@DirectXMan12 does #591 look any better to you?

yeah, let's switch to that one